Does not support NSLocalizedString #8

Closed
opened 2025-10-14 15:54:33 -06:00 by navan · 0 comments
Owner

Originally created by @AL-Mustapha01 on 1/3/2025

When using this dependency, it does allow initialization using NSLocalizedString. This is a huge issue when presenting WhatsNew to non English speaking audience

What solution would you like?

I see that title and subtitle are initialized as a Text, can you switch it to a String? This will also bolster cross-functionality between UIKit and SwiftUI.

What alternatives have you considered?

I have considered using other dependency libraries to present WhatsNew features

Any additional context?

Screenshot 2025-01-03 at 08 04 04
*Originally created by @AL-Mustapha01 on 1/3/2025* ### Is your feature request related to a problem? When using this dependency, it does allow initialization using NSLocalizedString. This is a huge issue when presenting WhatsNew to non English speaking audience ### What solution would you like? I see that title and subtitle are initialized as a Text, can you switch it to a String? This will also bolster cross-functionality between UIKit and SwiftUI. ### What alternatives have you considered? I have considered using other dependency libraries to present WhatsNew features ### Any additional context? <img width="1512" alt="Screenshot 2025-01-03 at 08 04 04" src="https://github.com/user-attachments/assets/a3358d52-c490-4229-b0e0-0012aeae3ae5" />
navan 2025-10-14 15:54:34 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github/WhatsNewKit#8
No description provided.