iOS 10 layout issues #94

New issue

Closed

opened 2025-10-14 16:00:48 -06:00 by navan · 0 comments

navan commented

2025-10-14 16:00:48 -06:00

Owner

Originally created by @Uragawa on 10/9/2018

I tried a basic WhatsNewViewController in my app. On the iOS 11 device, it works as expected. On the iOS 10 one, it seems that the order of statements while configuring the labels matters, as setting the font after setting the attributed text overwrites the attributes. Additionally, iOS 10 seems to require estimatedRowHeight to be either set or returned from the delegate for automatic sizing to work properly.

I forked the repo, fixed the issue back in the commit tagged with 1.1.1 (since I personally need Swift 4.1) and did a rebase, should I create a PR for this?

*Originally created by @Uragawa on 10/9/2018* I tried a basic WhatsNewViewController in my app. On the iOS 11 device, it works as expected. On the iOS 10 one, it seems that the order of statements while configuring the labels matters, as setting the font after setting the attributed text overwrites the attributes. Additionally, iOS 10 seems to require estimatedRowHeight to be either set or returned from the delegate for automatic sizing to work properly. I forked the repo, fixed the issue back in the commit tagged with 1.1.1 (since I personally need Swift 4.1) and did a rebase, should I create a PR for this?