feat: unified package #962

New issue

Open

opened 2025-10-14 18:13:05 -06:00 by navan · 0 comments

navan commented

2025-10-14 18:13:05 -06:00

Owner

Originally created by @wommy on 11/22/2024

Brief summary

unified client/package.json into root package.json

Which issue is fixed?

no specific issue,

but because there arent two package.json's anymore,
everything can just be ran from rootDir
eliminates the need for two npm ci's
simplifies the install and generation of the app

in the migration from nuxt 2 to 3, 3 comes with a /server/ directory
https://nuxt.com/docs/guide/directory-structure/server

tho i will still have to migrate all the logic from express into nitro and h3
https://h3.unjs.io/examples/from-expressjs-to-h3

i think it will be well worth it: removing dozens of outdate dependencies and boilerplate code, while simplifying logic and getting a nice speed increase

ill post a nice chatgpt analysis of that whenever my credits refill tomorrow

In-depth Description

cd client
git mv assets components layouts middleware mixins pages players plugins store strings cypress cypress.config.js nuxt.config.js tailwind.config.js ..
mv dist public static .nuxt ..
cd ..
here i copied the scripts, dependencies: deps, dev, and optional, from client/package.json into package.json, plus a few other misc edits, check the file
git rm -r client/
changed the line in server/Server.js from /client/dist/ to /dist/
changed the .gitignore
ran npm install so npmci would work
also ran npm audit fix to fix the fixable npm errors 59 => 42 cli link
and ran npm dedupe to remove ~75 duplicated packages from node_modules cli link

How have you tested this?

yes of course,

rm -rf node_modules
npm run client ; npm start
hit localhost:3333

and everything was perfectly there

i only have an epub and an audiobook, but they both played perfectly,

i navigated to each different view they all work normally,
which tracks because i didnt edit anything on the server
other than removing the /client prefix from the static app directory

Screenshots

no client changes

Additional - Left Undone - Unsure How to Proceed

i didnt edit a few misc files, ill split them into categories

simple

.devcontainer/post-create.sh, .vscode/launch.json, .vscode/tasks.json
- need slight tweaks
.dockerignore
- seems like the same few line changes from .gitignore

medium

Dockerfile
- dunno how STAGE 0 WORKDIR works, looks simple tho
- probs similar to the next one

harder

.github/workflows
- probs just swap /client w/ assets components layouts middleware mixins pages players plugins static store strings cypress cypress.config.js nuxt.config.js tailwind.config.js

*Originally created by @wommy on 11/22/2024*  ## Brief summary  unified `client/package.json` into root `package.json` ## Which issue is fixed?  no specific issue, but because there arent two `package.json`'s anymore, everything can just be ran from rootDir eliminates the need for two `npm ci`'s simplifies the install and generation of the app in the migration from nuxt 2 to 3, 3 comes with a `/server/` directory https://nuxt.com/docs/guide/directory-structure/server tho i will still have to migrate all the logic from express into nitro and h3 https://h3.unjs.io/examples/from-expressjs-to-h3 i think it will be well worth it: removing dozens of outdate dependencies and boilerplate code, while simplifying logic and getting a nice speed increase ill post a nice chatgpt analysis of that whenever my credits refill tomorrow ## In-depth Description  - `cd client` - `git mv assets components layouts middleware mixins pages players plugins store strings cypress cypress.config.js nuxt.config.js tailwind.config.js ..` - `mv dist public static .nuxt ..` - `cd ..` - here i copied the `scripts`, dependencies: `deps`, `dev`, and `optional`, from `client/package.json` into `package.json`, plus a few other misc edits, check the file - `git rm -r client/` - changed the line in `server/Server.js` from `/client/dist/` to `/dist/` - changed the `.gitignore` - ran `npm install` so `npmci` would work - also ran `npm audit fix` to fix the fixable npm errors 59 => 42 [cli link](https://docs.npmjs.com/cli/v10/commands/npm-audit) - and ran `npm dedupe` to remove ~75 duplicated packages from `node_modules` [cli link](https://docs.npmjs.com/cli/v10/commands/npm-dedupe) ## How have you tested this?  yes of course, - `rm -rf node_modules` - `npm run client ; npm start` - hit `localhost:3333` and everything was perfectly there i only have an epub and an audiobook, but they both played perfectly, i navigated to each different view they all work normally, which tracks because i didnt edit anything on the server other than removing the `/client` prefix from the static app directory ## Screenshots  no client changes --- ### Additional - Left Undone - Unsure How to Proceed i didnt edit a few misc files, ill split them into categories #### simple - `.devcontainer/post-create.sh`, `.vscode/launch.json`, `.vscode/tasks.json` - need slight tweaks - `.dockerignore` - seems like the same few line changes from `.gitignore` #### medium - `Dockerfile` - dunno how `STAGE 0 WORKDIR` works, looks simple tho - probs similar to the next one #### harder - `.github/workflows` - probs just swap `/client` w/ `assets components layouts middleware mixins pages players plugins static store strings cypress cypress.config.js nuxt.config.js tailwind.config.js`