Unable to write characters such as "@", "+" or "✓", even after adding them to the valid_char_set. Problem with _sample function. #57

New issue

Open

opened 2025-10-14 17:17:52 -06:00 by navan · 0 comments

navan commented

2025-10-14 17:17:52 -06:00

Owner

Originally created by @AIMLAPP on 7/13/2020

Hi,

I attempted to generate handwritten "@", "+" and "✓" signs, but was unable to.
E.g. the phone number +1234, and the email sample@email.com will not generate anything at all.

Within the "write" function of demo.py (line 42) => valid_char_set = set(drawing.alphabet), alphabet is called from drawing.py. Therefore, I modified within drawing.py (see line 10), the list alphabet by adding the new characters. Adding "@" or "+" to the list caused major problems as even regular words such as "John Smith" can no longer be written i.e. no handwriting output at all.

I have identified where within demo.py, the code breaks after adding the new characters to the list. The line strokes = self._sample(lines, biases=biases, styles=styles) (line 61), calls the function _sample. Within _sample, it is from line 94 to line 106, which fails (see below)

    [samples] = self.nn.session.run(
        [self.nn.sampled_sequence],
        feed_dict={
            self.nn.prime: styles is not None,
            self.nn.x_prime: x_prime,
            self.nn.x_prime_len: x_prime_len,
            self.nn.num_samples: num_samples,
            self.nn.sample_tsteps: max_tsteps,
            self.nn.c: chars,
            self.nn.c_len: chars_len,
            self.nn.bias: biases
        }
    )

Would anyone be able to provide an explanation and solution for this please? i.e. explanation to why nothing is drawn at all, and why adding an additional character could not solve this. And what the solution would be to generate handwriting for "@", "+" and "✓"?

Many Thanks!

PS: I also attempted on the web demo to create"@", "+" and "✓". Although not drawn properly, at least handwriting can be generated.

*Originally created by @AIMLAPP on 7/13/2020* Hi, I attempted to generate handwritten "@", "+" and "✓" signs, but was unable to. E.g. the phone number +1234, and the email sample@email.com will not generate anything at all. Within the **"write"** function of **demo.py** (line 42) => **valid_char_set = set(drawing.alphabet)**, alphabet is called from **drawing.py**. Therefore, I modified within **drawing.py** (see line 10), the list alphabet by adding the new characters. Adding "@" or "+" to the list caused major problems as even regular words such as "John Smith" can no longer be written i.e. no handwriting output at all. I have identified where within **demo.py**, the code breaks after adding the new characters to the list. The line **strokes = self._sample(lines, biases=biases, styles=styles)** (line 61), calls the function **_sample**. Within **_sample**, it is from **line 94 to line 106**, which fails (see below) [samples] = self.nn.session.run( [self.nn.sampled_sequence], feed_dict={ self.nn.prime: styles is not None, self.nn.x_prime: x_prime, self.nn.x_prime_len: x_prime_len, self.nn.num_samples: num_samples, self.nn.sample_tsteps: max_tsteps, self.nn.c: chars, self.nn.c_len: chars_len, self.nn.bias: biases } ) Would anyone be able to provide an explanation and solution for this please? i.e. explanation to why nothing is drawn at all, and why adding an additional character could not solve this. And what the solution would be to generate handwriting for "@", "+" and "✓"? Many Thanks! PS: I also attempted on the web demo to create"@", "+" and "✓". Although not drawn properly, at least handwriting can be generated.

No labels

dependencies

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github/handwriting-synthesis#57

No description provided.

Rows
Columns