Inconsistency in README for thankyou_message #161

New issue

Closed

opened 2025-10-14 16:32:07 -06:00 by navan · 0 comments

navan commented

2025-10-14 16:32:07 -06:00

Owner

Originally created by @timvink on 12/28/2018

Great resource, thanks for all the effort!

There's a inconsistency in the README causing the thankyou_message not to display. Might be confusing for some people.

The README says to use an id:

But in form-submission-handler.js it references the class:

          var thankYouMessage = form.querySelector(".thankyou_message");
          if (thankYouMessage) {
            thankYouMessage.style.display = "block";
          }

Solution is to update either the README (<div style="display:none;" class="thankyou_message">) or the javascript (form.querySelector("#thankyou_message");).

*Originally created by @timvink on 12/28/2018* Great resource, thanks for all the effort! There's a inconsistency in the README causing the thankyou_message not to display. Might be confusing for some people. The README says to use an `id`: ![image](https://user-images.githubusercontent.com/5570380/50512803-50e2f700-0a94-11e9-9ec8-e46d59a2eae7.png) But in `form-submission-handler.js` it references the `class`: ```js var thankYouMessage = form.querySelector(".thankyou_message"); if (thankYouMessage) { thankYouMessage.style.display = "block"; } ``` Solution is to update either the README (`<div style="display:none;" class="thankyou_message">`) or the javascript (`form.querySelector("#thankyou_message");`).