mirror of
https://github.com/oxalorg/sakura.git
synced 2026-04-03 00:08:52 -06:00
Buggy intgeraction of <code> and text-align: justify + my fix #17
Labels
No labels
dependencies
dependencies
dependencies
dependencies
dependencies
dependencies
dependencies
dependencies
dependencies
dependencies
dependencies
discussion
discussion
discussion
discussion
discussion
discussion
enhancement
enhancement
enhancement
enhancement
enhancement
enhancement
enhancement
enhancement
enhancement
good-first-issue
help wanted
help wanted
javascript
javascript
javascript
question
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github/sakura#17
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FrostKiwi on 12/26/2023
The following is (seemingly?) not a bug of Sakura.css in it's default config, but when in context of a paragraph that has
text-align: justify;active and a<code>tag present. Fixable viacode { white-space: unset; }I still wanted to mention it, in case anyone comes across this.
Both interact weirdly and cause a pet-peeve of mine, articles that should be horizontally scroll-locked, scrolling to the side as you try to read the article. There is this happening on this post in my Tech Blog https://blog.frost.kiwi, which uses Sakura.css.
https://github.com/oxalorg/sakura/assets/60887273/ba53950c-5e46-476f-82ce-23aa09048c39
You can see the article scrolling side to side, even though it should be locked in one column. Culprit is this
<code>block growing beyond the<main>tag's width, which hastext-align: justifyapplied.In my blog I fixed this via this commit and inserting a
code { white-space: unset; }in this line.With the fix applied, it now is a proper single column, without horizontal scrolling:
https://github.com/oxalorg/sakura/assets/60887273/8ecf41a4-fcff-460c-9c5f-2bdc0e2f98af